Removing TextString check to encode characters when writing bytes #226
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes extraneous code in the TextString primitive that would conditionally encode the individual string characters depending upon the version of Python being used. This code caused errors when using Unicode strings in Python 2.7 and below.
Current coverage is 86.93% (diff: 100%)@@ master #226 diff @@
==========================================
Files 64 64
Lines 8240 8237 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7164 7161 -3
Misses 1076 1076
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes extraneous code in the TextString primitive that would conditionally encode the individual string characters depending upon the version of Python being used. This code caused errors when using Unicode strings in Python 2.7 and below.